Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable SideBySide in MultiPathBlock #2096

Merged
merged 8 commits into from
Oct 11, 2024
Merged

Conversation

gabriele-ct
Copy link
Contributor

@gabriele-ct gabriele-ct commented Sep 30, 2024

Description of changes
Make the MultiPathBlock component able to display content side by side on wide viewports

Link to original ticket
#2090

Link to change (deep-link for reviewing the change)
https://docskit-ga-multipath-in-api.commercetools.vercel.app/api-docs-smoke-test/layouts/endpoint-large-desktop
https://docskit-ga-multipath-in-api.commercetools.vercel.app/docs-smoke-test/views/wide

Screenshot of changes (if applicable)
Screenshot 2024-10-01 at 15 17 40

DoD guidelines

  • user documentation added?
  • stakeholders approve changes? (if needed)

Copy link

changeset-bot bot commented Sep 30, 2024

🦋 Changeset detected

Latest commit: 5abbe97

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@commercetools-website/api-docs-smoke-test Patch
@commercetools-docs/gatsby-theme-docs Patch
@commercetools-website/docs-smoke-test Patch
@commercetools-website/documentation Patch
@commercetools-docs/ui-kit Patch
@commercetools-website/self-learning-smoke-test Patch
@commercetools-website/site-template Patch
@commercetools-docs/gatsby-theme-api-docs Patch
@commercetools-docs/gatsby-theme-code-examples Patch
@commercetools-docs/gatsby-theme-constants Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 30, 2024

@gabriele-ct gabriele-ct marked this pull request as ready for review October 1, 2024 13:13
@gabriele-ct gabriele-ct requested a review from a team October 1, 2024 13:13
@gabriele-ct gabriele-ct linked an issue Oct 1, 2024 that may be closed by this pull request
Copy link
Contributor

@ColinRosati ColinRosati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/ui-kit/src/components/multi-path-block.tsx Outdated Show resolved Hide resolved
@gabriele-ct gabriele-ct merged commit dc29d10 into main Oct 11, 2024
10 checks passed
@gabriele-ct gabriele-ct deleted the ga-multipath-in-api branch October 11, 2024 09:17
@ct-changesets ct-changesets bot mentioned this pull request Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for sidebyside component into multipath component
2 participants