DEVX-390 - PHP sdk set up for Datadog #227
Conversation
barbara79
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #227 +/- ##
=========================================
Coverage 12.69% 12.69%
Complexity 115170 115170
=========================================
Files 9311 9311
Lines 285681 285681
=========================================
Hits 36260 36260
Misses 249421 249421 ☔ View full report in Codecov by Sentry. |
barbara79
changed the title
jenschude
force-pushed
the
datadog-sdk
branch
from
fa48dae
to
4c9e40e
Compare
| @@ -0,0 +1,32 @@ | |||
| # Dockerfile for New Relic | |||
| FROM php:8.2-fpm | |||
There was a problem hiding this comment.
keeping this file because will need it in the next task
| - DD_SERVICE=symfony-app | ||
| - DD_AGENT_HOST=datadog-agent | ||
| - DD_TRACE_AGENT_PORT=8126 | ||
| - DD_API_KEY=${DD_API_KEY} | ||
| - DD_TRACE_DEBUG=true | ||
| - DD_LOGS_ENABLED=true | ||
| - DD_PROCESS_AGENT_ENABLED=true |
There was a problem hiding this comment.
So the env vars like DD_AGENT_HOST, DD_SERVICE etc. are not taken from .env file?
There was a problem hiding this comment.
this is a good question, I tried to remove them from here but it doesn't work: some variables are taken from the .env file some of them not. The .env file is more for the symfony framework, so for the application
Co-authored-by: Lam Tran <[email protected]>
Co-authored-by: Lam Tran <[email protected]>
Co-authored-by: Lam Tran <[email protected]>
Co-authored-by: Lam Tran <[email protected]>
|
btw. did you test also for dogstatsd protocol? https://docs.datadoghq.com/developers/dogstatsd/?tab=hostagent. This was explicitly required by a customer in the past, so we had to test it as well in Java: https://commercetools.atlassian.net/browse/DEVX-317 |
I didn't know, I will check it and test it. |
I'm gonna create another task for this issue, since this task wasn't included in the main one. |
Features
Fixes
Breaking changes