Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix intermittent test failures caused by the TestAggregatePromotionPlan test #24

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

jared-logan-patrick-ct
Copy link

Description

This PR resolves intermittent test suite execution failures that are caused by the TestAggregatePromotionPlan test.

JIRA Issue

The function signature for generatePromotionPlanTestHelper has been modified to support a variadic expected promotions parameter.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@jared-logan-patrick-ct jared-logan-patrick-ct changed the title convert the promotion plan test helper function to use a variadic par… fix intermittent test failures caused by the TestAggregatePromotionPlan test Sep 3, 2024
@jared-logan-patrick-ct jared-logan-patrick-ct marked this pull request as ready for review September 3, 2024 20:15
@jared-logan-patrick-ct jared-logan-patrick-ct marked this pull request as draft September 4, 2024 18:28
@jared-logan-patrick-ct jared-logan-patrick-ct marked this pull request as ready for review September 4, 2024 18:30
Copy link

@ashvarts ashvarts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hnnsgstfssn hnnsgstfssn merged commit d4cf1aa into main Sep 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants