Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help user to debug the diff error with temporary applications #26

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

yzdann
Copy link

@yzdann yzdann commented Sep 6, 2024

Description

In some cases, users cannot get the diff from ArgoCD due to an error on diffing.
This is normally because the NormalizedLiveState is empty due to an app condition error.
In this case, we should keep the temporary application for investigation purposes, and let the user know how to debug it.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@yzdann yzdann self-assigned this Sep 6, 2024
@yzdann yzdann marked this pull request as ready for review September 9, 2024 09:20
@yzdann yzdann merged commit bbe49ea into main Sep 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants