re-enable hledger, hledger-ui, hledger-lib

[simonmichael]

hledger* 1.33.1 supports ghc 9.8 and current stackage nightly.

[simonmichael]

I think the check failure is unrelated and this is ready to go.

[simonmichael]

Ping

[juhp]

Sorry for the delay - I think I fixed this maybe separately with a commenter mass update just now - yeah sorry should have checked here first... :-/

[juhp]

There was one error:

       Running tests for hledger-web 1.33.1, linux-x86_64
       test: setupTerm: Couldn't look up terminfo entry "unknown"

So I let the testsuite fail for now

[simonmichael]

That commit was 6861767. Thank you @juhp!

When is that test suite being run ? I guess not in the PR check workflow (eg #7413). Strange that the term-using hledger-ui doesn't fail similarly. I'll try to resolve it.

[juhp]

When is that test suite being run ? I guess not in the PR check workflow (eg #7413). Strange that the term-using hledger-ui doesn't fail similarly. I'll try to resolve it.

Unfortunately the PR check (which is basically equivalent to the ./check script in the repo) only checks for bounds.
With the number of packages and churn, it is not really feasible to easily fully testing building stackage in CI, though yeah in theory we could try to build the packages in question: that would need some scripting to extract the packages from the PR: may not always be obvious - though people are supposed to do basic sanity build checks beforehand, but of course the environment is different so failures can still happen like in this case anyway. There is certainly room for improvement in the tooling, but sadly the curators have very little time for such things.

So to answer your question testsuites are built and run by curator incrementally when not disabled as part of the snapshot builds.