Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add csv-conduit #7528

Merged

Conversation

dmvianna
Copy link
Contributor

Checklist:

  • [ ✓] Meaningful commit message, eg add my-cool-package (please don't mention build-constraints.yml)
  • [ ✓] At least 30 minutes have passed since uploading to Hackage
  • [ ✓] If applicable, required system libraries are added to 02-apt-get-install.sh or 03-custom-install.sh
  • [ ✓] (recommended) Package have been verified to work with the latest nightly snapshot, e.g by running the verify-package script
  • [ ✓] (optional) Package is compatible with the latest version of all dependencies (Run cabal update && cabal outdated)

The script runs virtually the following commands in a clean directory:

  stack unpack $package-$version # `-$version` is optional
  cd $package-$version
  rm -f stack.yaml && stack init --resolver nightly --ignore-subdirs
  stack build --resolver nightly --haddock --test --bench --no-run-benchmarks

@dmvianna dmvianna changed the title add csv-conduit maintainer add csv-conduit Sep 30, 2024
@alexeyzab
Copy link
Contributor

Hi there! Looks like csv-conduit is already in the build-constraints: https://github.com/commercialhaskell/stackage/blob/master/build-constraints.yaml#L889, if you're taking over as the maintainer, would you mind deleting that line?

Also, do you know if this failure is no longer relevant?
https://github.com/commercialhaskell/stackage/blob/master/build-constraints.yaml#L6567

@dmvianna
Copy link
Contributor Author

dmvianna commented Oct 2, 2024

Hi there! Looks like csv-conduit is already in the build-constraints: https://github.com/commercialhaskell/stackage/blob/master/build-constraints.yaml#L889, if you're taking over as the maintainer, would you mind deleting that line?

Done.

Also, do you know if this failure is no longer relevant? https://github.com/commercialhaskell/stackage/blob/master/build-constraints.yaml#L6567

I have run ./verify-package csv-conduit locally and it built just fine. Also, our CI builds with many Stack-LTS releases without a glitch.

@dmvianna
Copy link
Contributor Author

dmvianna commented Oct 2, 2024

Here's the LTS releases we have built against.

@alexeyzab
Copy link
Contributor

Thank you!

@alexeyzab alexeyzab merged commit 306a4a0 into commercialhaskell:master Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants