Added recursive_resolve_and_validate_document #1375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mr-c
approved these changes
Nov 17, 2020
Codecov Report
@@ Coverage Diff @@
## main #1375 +/- ##
==========================================
+ Coverage 77.87% 77.88% +0.01%
==========================================
Files 41 41
Lines 7698 7702 +4
Branches 1963 1963
==========================================
+ Hits 5995 5999 +4
Misses 1209 1209
Partials 494 494
Continue to review full report at Codecov.
|
mr-c
requested changes
Nov 17, 2020
cwltool/load_tool.py
Outdated
| uri: str, | ||
| preprocess_only: bool = False, | ||
| skip_schemas: Optional[bool] = None, | ||
| ) -> Tuple[LoadingContext, str]: |
There was a problem hiding this comment.
Suggested change
| ) -> Tuple[LoadingContext, str]: | |
| ) -> Tuple[LoadingContext, str, Process]: |
from make mypy
|
Thank you @simleo ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like
resolve_and_validate_document, but it also callsmake_tool, bringing in additional validation.Discussed in galaxyproject/gxformat2#51.