Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CWL inputs section to schema salad #1748

Closed
wants to merge 2 commits into from
Closed

Conversation

mr-c
Copy link
Member

@mr-c mr-c commented Oct 5, 2022

  • move preamble to static file (or public file that gets $included?)
  • tests

@mr-c mr-c requested a review from mvdbeek October 5, 2022 15:44
@mr-c mr-c force-pushed the input_object_schema_salad branch from 3e4a693 to 591bb5f Compare October 5, 2022 15:58
@codecov
Copy link

codecov bot commented Oct 6, 2022

Codecov Report

Merging #1748 (c6ce1e6) into main (0f4459c) will decrease coverage by 0.36%.
The diff coverage is 14.28%.

@@            Coverage Diff             @@
##             main    #1748      +/-   ##
==========================================
- Coverage   82.17%   81.81%   -0.37%     
==========================================
  Files          47       47              
  Lines        8058     8098      +40     
  Branches     2191     2202      +11     
==========================================
+ Hits         6622     6625       +3     
- Misses        947      983      +36     
- Partials      489      490       +1     
Impacted Files Coverage Δ
cwltool/main.py 70.86% <10.00%> (-3.44%) ⬇️
cwltool/argparser.py 95.23% <100.00%> (+0.01%) ⬆️
cwltool/load_tool.py 86.66% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@mr-c mr-c marked this pull request as ready for review October 7, 2022 09:19
@mr-c
Copy link
Member Author

mr-c commented Oct 18, 2022

This was a fun experiment. As explained in common-workflow-lab/galaxy#145 (comment) it is no longer needed

@mr-c mr-c closed this Oct 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant