Upgrade to use Python 3, fixes #11 #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- first trial using warc3-wet as replacement for the 'warc' library
- based on an updated version of the warc library
supporting Python 3, see
https://github.com/commoncrawl/warc/
- optionally replaces by a compatibility-wrapper around
warcio (https://pypi.org/project/warcio/)
and
fastwarc (https://resiliparse.chatnoir.eu/en/latest/api/fastwarc.html)
- if fileobj is passed to WARC/ARC constructor: need to also pass whether file is compressed following the file name suffix
The get-data script uses bash's array syntax, which causes an error if you actually try to use it with `sh`, so you might as well explicitly run it with bash.
Specify bash in get-data.sh
- update download links for sample WARC/WAT/WET files - remove unauthenticated access in boto3 s3 client configuration Update documentation, fix broken links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: