Skip to content

Commit

Permalink
CommonsApplication migrate to kotlin & some lint fixes (#5879)
Browse files Browse the repository at this point in the history
* convert to kotlin

Signed-off-by: parneet-guraya <[email protected]>

* use lateinit instead of nullable types

Signed-off-by: parneet-guraya <[email protected]>

* instance property access fix

Signed-off-by: parneet-guraya <[email protected]>

* refactor constants name with uppercased ones

Signed-off-by: parneet-guraya <[email protected]>

* remove unused

Signed-off-by: parneet-guraya <[email protected]>

* fix imports in test

Signed-off-by: parneet-guraya <[email protected]>

* use mockk for kotlin to fix tests

Signed-off-by: parneet-guraya <[email protected]>

---------

Signed-off-by: parneet-guraya <[email protected]>
  • Loading branch information
parneet-guraya authored Oct 26, 2024
1 parent 7c58891 commit bc065c8
Show file tree
Hide file tree
Showing 10 changed files with 436 additions and 445 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ class AboutActivityTest {
fun testLaunchTranslate() {
Espresso.onView(ViewMatchers.withId(R.id.about_translate)).perform(ViewActions.click())
Espresso.onView(ViewMatchers.withId(android.R.id.button1)).perform(ViewActions.click())
val langCode = CommonsApplication.getInstance().languageLookUpTable.codes[0]
val langCode = CommonsApplication.instance.languageLookUpTable!!.codes[0]
Intents.intended(
CoreMatchers.allOf(
IntentMatchers.hasAction(Intent.ACTION_VIEW),
Expand Down
Loading

0 comments on commit bc065c8

Please sign in to comment.