-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix resource leak bug #5251
Fix resource leak bug #5251
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! For the sake of reference, could you kindly clarify how you came across this resource leakage issue ? 🤔
app/src/main/java/fr/free/nrw/commons/filepicker/PickedFiles.java
Outdated
Show resolved
Hide resolved
we investigated open-source projects to see if the projects contain code that is similar to (or reused from) Stack Overflow and whether the code on Stack Overflow underwent any bug or security fixes. We found that the code in this method is somewhat similar to the one in the first version of this answer. The issue was subsequently fixed in the second version, however, the fix is not reflected in this method. So this PR is a way of notifying about the issue |
Signed-off-by: Alfusainey Jallow <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we investigated open-source projects to see if the projects contain code that is similar to (or reused from) Stack Overflow and whether the code on Stack Overflow underwent any bug or security fixes. We found that the code in this method is somewhat similar to the one in the first version of this answer. The issue was subsequently fixed in the second version, however, the fix is not reflected in this method.
So this PR is a way of notifying about the issue
Great. Thanks for the helpful work! Much appreciated 🙂
app/src/main/java/fr/free/nrw/commons/filepicker/PickedFiles.java
Outdated
Show resolved
Hide resolved
@sivaraam I updated the PR to incorporate your comments. Can you please take another look? |
app/src/main/java/fr/free/nrw/commons/filepicker/PickedFiles.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Alfusainey Jallow <[email protected]>
Looks great. Thank your for your contribution! |
Description (required)
This patch fixes a potential resource leak bug in the event that an exception is thrown during the copy operation