Makes depicted place and category items unselectable for nearby place

[srishti-R]

Description (required)

Fixes #5317

What changes did you make and why?
Makes the place and category unselectable

Tests performed (required)

Tested {prodDebug} on {pixel 5 emulator} with API level {34, 30}.

Screenshots (for UI changes only)

Need help? See https://support.google.com/android/answer/9075928

---

Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.

[nicolas-raoul]

I just tested with a Wikidata item that has no associated category (https://www.wikidata.org/wiki/Q105799610 embassy of Brazil in Costa Rica), it seems like a strange "Hidden" category is shown instead of nothing being pre-selected:

screen-20231003-224913.mp4

It seems to work great with Fukusho-ji (which has an associated category).

[srishti-R]

I just tested with a Wikidata item that has no associated category (https://www.wikidata.org/wiki/Q105799610 embassy of Brazil in Costa Rica), it seems like a strange "Hidden" category is shown instead of nothing being pre-selected:

It seems to work great with Fukusho-ji (which has an associated category).

I thought this was intended, will remove.

[srishti-R]

@nicolas-raoul made the requested changes, "hidden" is no longer a category that appears checked when no category is there. Need some help with 2 failing tests inside CategoriesPresenterTests.kt, I have never written tests for RxJava before and I have used up every brain cell available to fix those two.

[nicolas-raoul]

Note: Just tested, it works great now, thanks! I did not actually upload any file but I will try to, probably in the next few days.

About the unit tests: Would you mind creating a new issue about it? Please include Git repo/branch info to make it easily reproducible. Thanks! :-)

[srishti-R]

@nicolas-raoul I was able to fix all the CategoriesPresenter failing tests as here #5327. One confirmation I needed to make this deselectable feature better. Suppose we upload a set of images that have exif attached, we confirm by saying "Yes" to "is this a photo of some place nearby?", after this, shouldn't the depiction and category also be unselectable? Currently its not. We can choose to select/unselect the depiction and category in this specific case.

[nicolas-raoul]

Tested again, it still works great (I did not actually finish the upload though as I did not have suitable pictures)

[nicolas-raoul]

When using Nearby, the app does assign the uploaded picture to the Wikidata item. Even if the user changes their mind they have no way to prevent this assignment from taking place. So if they change their mind, they MUST just cancel their upload.

On the other side, even after selecting "Yes" for "is this a photo of some place nearby?", the user can still modify everything (captions/descriptions/depictions/categories), and it will be like if they has selected "No". The Wikidata item is not modified.

Summary: Nearby upload MUST be about that Wikidata item. Normal upload does not have such restrictions.