Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tick icon in place of number of images selected in custom picker #5331

Merged
merged 2 commits into from
Oct 9, 2023

Conversation

srishti-R
Copy link
Contributor

Description (required)

Fixes #5243

What changes did you make and why?

Tests performed (required)

Tested prodDebug on Samsung galaxy M31 with API level 31.

Screenshots (for UI changes only)
Screenshot_20231008-220838_Commons

Need help? See https://support.google.com/android/answer/9075928


Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.

@srishti-R
Copy link
Contributor Author

Not sure about the UI here, I tried using a drawable already present in codebase for tick icon.

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Selection and upload work great.

Would you mind making the tick color visible in dark mode? 🙂

Screenshot_20231009-084742.png

@srishti-R
Copy link
Contributor Author

@nicolas-raoul fixed the ui a bit in addition to dark mode fixes and tests, the tick icon is now a bit bold, I feel its more visible now that earlier.
Screenshot_20231009-074727_Commons

Copy link
Member

@nicolas-raoul nicolas-raoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks!

@nicolas-raoul nicolas-raoul merged commit 0d90ac3 into commons-app:main Oct 9, 2023
1 check passed
@nicolas-raoul
Copy link
Member

nicolas-raoul commented Mar 30, 2024

Hi @srishti-R

Sorry for hijacking this thread, but did you submit a proposal?
I can't see any at https://phabricator.wikimedia.org/project/view/6921/

You have good chances, so please do not hesitate unless you have other plans :-)
Just copy/pasting the tasks list from https://phabricator.wikimedia.org/T356237 and adding a minimal schedule (start/finish dates) is enough.
The deadline is April 2 - 18:00 UTC.

@srishti-R
Copy link
Contributor Author

Hi @srishti-R

Sorry for hijacking this thread, but did you submit a proposal? I can't see any at https://phabricator.wikimedia.org/project/view/6921/

You have good chances, so please do not hesitate unless you have other plans :-) Just copy/pasting the tasks list from https://phabricator.wikimedia.org/T356237 and adding a minimal schedule (start/finish dates) is enough. The deadline is April 2 - 18:00 UTC.

Hi @nicolas-raoul, thank you for the reminder, but this year I have some other unforeseen personal commitments, so I won't be able to dedicate time completely to any project I pick. Nevertheless, I would love to contribute as and when I get time in between.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom picker: Replace numbers with ticks, and display total number of selected pictures in title
2 participants