-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tick icon in place of number of images selected in custom picker #5331
Tick icon in place of number of images selected in custom picker #5331
Conversation
Not sure about the UI here, I tried using a drawable already present in codebase for tick icon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nicolas-raoul fixed the ui a bit in addition to dark mode fixes and tests, the tick icon is now a bit bold, I feel its more visible now that earlier. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thanks!
Hi @srishti-R Sorry for hijacking this thread, but did you submit a proposal? You have good chances, so please do not hesitate unless you have other plans :-) |
Hi @nicolas-raoul, thank you for the reminder, but this year I have some other unforeseen personal commitments, so I won't be able to dedicate time completely to any project I pick. Nevertheless, I would love to contribute as and when I get time in between. |
Description (required)
Fixes #5243
What changes did you make and why?
Tests performed (required)
Tested prodDebug on Samsung galaxy M31 with API level 31.
Screenshots (for UI changes only)
Need help? See https://support.google.com/android/answer/9075928
Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.