Fix #5711 Incorrect rotation in Edit Image while uploading. #5760
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #5711. While uploading, when click "Edit Image" and then perform no rotation (click Save, or click Rotate 4 times to get back to the original position and Save), the image will be automatically rotated 90 degrees.
What changes did you make and why?
Change rotateImage() function implementation in
edit/TransformImageImpl.kt
. When the given degree is not expected (e.g 0), the transformation of the image should be default instead of rotating 90 degree (LLJTran.ROT_90
).Tests performed (required)
Tested on Pixel 8 with API level 35.
Reproduce:
Error Behavior:
error_final.mp4
Expected Behavior:
The image will be shown as original instead of being rotated 90 degree after clicking "Save".
Screenshots (for UI changes only)
expected_final.mp4