(fixes #2872) Refactoring unused files for "showcase view whole nearby activity"

[devbytespark]

Description (required)

The refactored showcase nearby activity previously relied on a hardcoded string located in this file. This resulted in some inconsistency between the two activities.

Fixes #2872

---

What changes did you make and why?

While the best approach would be to parameterize the string with the key showcase_view_whole_nearby_activity to ensure consistency, the activity that previously utilized that layout has been removed. Consequently, the initial approach with the following pseudo-code is no longer applicable:

Parameterise the showcase string

<string name="showcase_view_whole_nearby_activity">These are the places near you that need pictures to illustrate their Wikipedia articles.\n\nClicking on \'%1$s' locks the map and launches a nearby search around that location.</string>

<string name="search_this_area">Search this area</string>

Set the showcase string to use the search_this_area string

String searchString = getString(R.string.search_this_area);
String message = String.format(getString(R.string.showcase_view_whole_nearby_activity), searchString);

As a temporary workaround, I have edited the hardcoded string to ensure it aligns with the expected output from the search_this_area string and disabled the automatic capitalization flag in the button for consistency.

---

Tests performed (required)
Tested on ProdDebug on Pixel 9 with API level 34 to ensure consistency with the capitalization as shown in the following two screenshots.

Before the change:

After the change:

[nicolas-raoul]

There is no "Search this area" button anymore.
Actually, is this string used somewhere? If you find where it is used, would you mind posting a screenshot?
Thanks a lot! 🙂

[devbytespark]

I found that it was used in dialog_nearby.xml, but I believe the activity using the layout has been refactored.

[nicolas-raoul]

Would you mind trying to remove it? Any impact? 🙂

[devbytespark]

Deleting the button and its string seems fine

[devbytespark]

Hey Nicholas after further review I noticed that the dialog_nearby.xml file had no usages in the whole app. I’ve safely deleted the file along with its associated string resources, and the project still builds without issues.

It seems the file was part of the old webview in the nearby section of the contributions activity, likely from a version of the app prior to refactoring.