add an activity check for the permission check #5900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misaochan
requested changes
Nov 16, 2024
| if (str1.equals(str2)) return 0; | ||
| if (str1.length() == 0) return str2.length(); | ||
| if (str2.length() == 0) return str1.length(); | ||
| if (str1.equals(str2)) { |
There was a problem hiding this comment.
There appear to be a lot of formatting changes in this PR. In my opinion these changes do make the code more readable, however they aren't relevant to the issue being addressed. Could you please revert the formatting changes and only keep the code changes? Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description (required)
Fixes #INSERT_ISSUE_NUMBER_HERE
What changes did you make and why?
Added SecurityException Handling:
Wrapped the creation of DownloadManager.Request in a try-catch block to handle SecurityException if storage permission is missing. This prevents the app from crashing when permissions are revoked during download.
Checked for Non-null activity Before Enqueuing:
Added a null check for activity before calling enqueueRequest. This ensures the activity is still valid, especially when permissions are revoked or the activity is recreated.
Enhanced Documentation:
Added detailed doc comments for the class and each method, explaining the purpose and functionality of the code, making it more readable and maintainable.
Tests performed (required)
Tested {build variant, e.g. ProdDebug} on {name of device or emulator} with API level {API level}.
ProdDebug on samsung zflip6, 34 api
Screenshots (for UI changes only)
Need help? See https://support.google.com/android/answer/9075928
Note: Please ensure that you have read CONTRIBUTING.md if this is your first pull request.