-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Robot scene rhino8 #23
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know enough to review these things. What is the difference from compas_invocation2 from the original one? Does these new tools changes the coding style or is simply a drop-in replacement of the old pep8 tools?
Just so I know if I should do the same for compas_fab...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. ruff
is pretty much a drop-in for all these other linting and formatting tools we were previously using.
It's part of a bigger effort to reduce our dependencies and consolidate all these different configuration files (setup.py
, setup.conf
, .bumpversion.cfg
etc.) into a single pyproject.toml
file. Take a look at core for example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know
late to the party, but 🚀 !! Awesome, thanks! |
RobotModelObject
to not get registered in contextRhino
.compas_invocations2
cause it's almost 2025 ;)ruff
and the configuration that goes with it.What type of change is this?
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.md
file in theUnreleased
section under the most fitting heading (e.g.Added
,Changed
,Removed
).invoke test
).invoke lint
).