Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robot scene rhino8 #23

Merged
merged 7 commits into from
Oct 2, 2024
Merged

Robot scene rhino8 #23

merged 7 commits into from
Oct 2, 2024

Conversation

chenkasirer
Copy link
Member

@chenkasirer chenkasirer commented Oct 1, 2024

  • Fixed some imports that were no longer working in Rhino8 which caused the RobotModelObject to not get registered in context Rhino.
  • Also upgraded to compas_invocations2 cause it's almost 2025 ;)
  • Replaced other linting tools with ruff and the configuration that goes with it.

What type of change is this?

  • Bug fix in a backwards-compatible manner.
  • New feature in a backwards-compatible manner.
  • Breaking change: bug fix or new feature that involve incompatible API changes.
  • Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I added a line to the CHANGELOG.md file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
  • I ran all tests on my computer and it's all green (i.e. invoke test).
  • I ran lint on my computer and there are no errors (i.e. invoke lint).
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know enough to review these things. What is the difference from compas_invocation2 from the original one? Does these new tools changes the coding style or is simply a drop-in replacement of the old pep8 tools?

Just so I know if I should do the same for compas_fab...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. ruff is pretty much a drop-in for all these other linting and formatting tools we were previously using.

It's part of a bigger effort to reduce our dependencies and consolidate all these different configuration files (setup.py, setup.conf, .bumpversion.cfg etc.) into a single pyproject.toml file. Take a look at core for example.

Copy link
Contributor

@yck011522 yck011522 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know

@chenkasirer chenkasirer merged commit 13cff6a into main Oct 2, 2024
14 checks passed
@chenkasirer chenkasirer deleted the robot_scene_rhino8 branch October 2, 2024 09:37
@gonzalocasas
Copy link
Member

late to the party, but 🚀 !! Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants