Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install missing dependencies MacOS cppyy jobs #125

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mcbarton
Copy link
Collaborator

@mcbarton mcbarton commented Jan 23, 2025

There are a lot of tests failing for things simply not being installed on MacOS. Hopefully by installing these cppyy will get more passing tests on MacOS. See here about missing dependencies https://github.com/compiler-research/CppInterOp/actions/runs/12925582648/job/36047197449#step:14:7103

@mcbarton mcbarton force-pushed the Install-needed-deps-for-MacOS-cppyy-tests branch from a402ced to ddc7891 Compare January 23, 2025 16:26
test/test_lowlevel.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@Vipul-Cariappa Vipul-Cariappa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this. The changes look good to me.

If you can make the change I have specified, it would be helpful. skip should only be used when we are missing libraries/dependencies, otherwise it should always be xfail.

test/test_lowlevel.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants