Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(runtime): return Task in spawn_blocking #221

Merged
merged 1 commit into from
Mar 7, 2024
Merged

refactor(runtime): return Task in spawn_blocking #221

merged 1 commit into from
Mar 7, 2024

Conversation

Berrysoft
Copy link
Member

I think it's not a breaking change.

@Berrysoft Berrysoft added enhancement New feature or request package: runtime Related to compio-runtime refactor Refactoring existing code labels Mar 7, 2024
@Berrysoft Berrysoft self-assigned this Mar 7, 2024
George-Miao
George-Miao approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@George-Miao George-Miao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Berrysoft Berrysoft merged commit c67be0d into compio-rs:master Mar 7, 2024
29 checks passed
@Berrysoft Berrysoft deleted the refactor/spawn-blocking-task branch March 7, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@George-Miao George-Miao George-Miao approved these changes

Assignees

@Berrysoft Berrysoft

Labels
enhancement New feature or request package: runtime Related to compio-runtime refactor Refactoring existing code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Berrysoft @George-Miao