Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(buf): make IoBuf(Mut) unsafe #222

Merged
merged 1 commit into from
Mar 7, 2024
Merged

fix(buf): make IoBuf(Mut) unsafe #222

merged 1 commit into from
Mar 7, 2024

Conversation

Berrysoft
Copy link
Member

Closes #220

@Berrysoft Berrysoft added bug Something isn't working package: buf Related to compio-buf labels Mar 7, 2024
@Berrysoft Berrysoft self-assigned this Mar 7, 2024
George-Miao
George-Miao approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@George-Miao George-Miao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change. We need to wait til 0.10 before releasing.

@Berrysoft
Copy link
Member Author

Berrysoft commented Mar 7, 2024 •
edited
Loading

We will continue maintaining 0.9 in dev/v0.9

And then we can happily apply breaking changes to master.

@Berrysoft Berrysoft merged commit 4631553 into compio-rs:master Mar 7, 2024
29 checks passed
@Berrysoft Berrysoft deleted the unsafe-iobuf branch March 7, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@George-Miao George-Miao George-Miao approved these changes

Assignees

@Berrysoft Berrysoft

Labels
bug Something isn't working package: buf Related to compio-buf
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IoBuf should be a unsafe trait
2 participants
@Berrysoft @George-Miao