Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(driver,iour): remove outer squeue #227

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

Berrysoft
Copy link
Member

I'm not sure if the change is wise. It removes the outer squeue, and the operations will report errors when the squeue is full. It might be an optimization, but may produce errors to the user in the case that only stucks the runtime previously.

@Berrysoft Berrysoft added driver: io-uring About the io-uring driver package: driver Related to compio-driver labels Mar 12, 2024
@Berrysoft Berrysoft self-assigned this Mar 12, 2024
compio-driver/src/iour/mod.rs Outdated Show resolved Hide resolved
compio-driver/src/iour/mod.rs Outdated Show resolved Hide resolved
compio-driver/src/iour/mod.rs Outdated Show resolved Hide resolved
Copy link
Member

@George-Miao George-Miao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Berrysoft Berrysoft merged commit 14361dd into compio-rs:master Mar 12, 2024
29 checks passed
@Berrysoft Berrysoft deleted the fix/iour-squeue branch March 12, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
driver: io-uring About the io-uring driver package: driver Related to compio-driver
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants