Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'highlight' configuration values missing #253

Closed
bryfox opened this issue Oct 9, 2018 · 2 comments
Closed

'highlight' configuration values missing #253

bryfox opened this issue Oct 9, 2018 · 2 comments
Assignees
Labels
Architect Architect

Comments

@bryfox
Copy link
Contributor

bryfox commented Oct 9, 2018

On the sociogram, Network Canvas will look for a highlight property and set the variable to its value.

Architect doesn't set value, so attributes won't be toggled.

  • Architect should allow value configuration
  • Architect needs to also allow configuring the value type (or document otherwise)?
  • Should Architect default value to true?
  • Should Network Canvas infer an undefined value to be truthy (since undefined results in a no-op)?
@bryfox bryfox added the Architect Architect label Oct 9, 2018
@wwqrd wwqrd self-assigned this Oct 10, 2018
@wwqrd
Copy link
Contributor

wwqrd commented Oct 10, 2018

We did decide to only allow boolean variables here, which are only ever going to have a value of true. Making the value config is redundant. So perhaps we should remove it outright.

However, if we want to keep the flexibility of having a value prop, my feeling is that we shouldn't default in NC, as the variable type could be non-boolean.

@wwqrd
Copy link
Contributor

wwqrd commented Oct 10, 2018

@wwqrd wwqrd closed this as completed Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Architect Architect
Development

No branches or pull requests

2 participants