-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initialise all node attributes on node creation #710
Comments
Just for clarity: this means any values from the node form will override these default values. |
I assume this issue also covers "Sociogram highlight props should actually toggle true/false". Presently, I'd assume that the mere presence of |
If the intent is to require everything in the network to have props, then I assume external data should also be updated when added. I also assume we'll add only the attributes relevant to the In either case, |
Context: Sociogram highlight props should actually toggle true/false, they’re currently added and removed. If we changed that to flip the value, at which point should the attribute have been added?
It was decided that actually nodes shouldn't have any missing attributes, and that they should all be initialised on node creation with blank values as follows:
Boolean:
false
Everything else:
null
If any attributes are provided when the node is created, these attributes should be set with the provided values.
Related: https://github.com/codaco/Architect/issues/253
The text was updated successfully, but these errors were encountered: