Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds main_comp_only to create_new_with_filter in ssp.py #179

Merged
merged 2 commits into from
Mar 1, 2024

Conversation

jpower432
Copy link
Contributor

Description

The main component is needed in a trestle SSP for it be valid. This has been added by default when filtering by components in workspace component definitions and option added to filter out all component but the main.

Type of change

  • New feature (non-breaking change which adds functionality) Not user facing feature

How has this been tested?

  • Updated unit tests

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

The main component is needed in a trestle SSP for it be valid.
This has been added by default when filtering by components in
workspace component definitions and option added to filter out all
component but the main.

Signed-off-by: Jennifer Power <[email protected]>
@jpower432 jpower432 marked this pull request as ready for review February 29, 2024 22:24
Copy link
Contributor

@beatrizmcouto beatrizmcouto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpower432 jpower432 merged commit 398c196 into main Mar 1, 2024
11 checks passed
@jpower432 jpower432 deleted the PSCE-351 branch March 1, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants