Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removes input repository from the safe workspace #185

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

jpower432
Copy link
Contributor

@jpower432 jpower432 commented Mar 4, 2024

Description

The input repository should always exist in the GitHub workspace. Setting it again in the entrypoint is redundant.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

  • Verified compatibility with GitHub Actions here

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (on chore: updates descriptions on actions inputs to be more precise #184)
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@jpower432 jpower432 marked this pull request as ready for review March 6, 2024 21:40
@jpower432 jpower432 requested a review from beatrizmcouto March 6, 2024 21:40
Copy link
Contributor

@beatrizmcouto beatrizmcouto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes made for safety, simplicity, lgtm

The input repository should always exist in the GitHub workspace.
Setting it again in the entrypoint is redundant.

Signed-off-by: Jennifer Power <[email protected]>
@jpower432 jpower432 force-pushed the chore/remove-safe-directory branch from 6a30b8c to 4c772e0 Compare March 12, 2024 17:37
@jpower432
Copy link
Contributor Author

@beatrizmcouto Re-pushed the commit. No changes, just fixed an issue with signing.

@jpower432 jpower432 merged commit 983384e into main Mar 12, 2024
9 checks passed
@jpower432 jpower432 deleted the chore/remove-safe-directory branch March 13, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants