-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: replaces 'check_only' with 'dry_run' option #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
jpower432
force-pushed
the
feat/replace-check-only
branch
from
March 25, 2024 16:34
e5dcf67
to
24d5ac9
Compare
jpower432
added
enhancement
New feature or request
breaking_change
Backward incompatible changes
labels
Mar 25, 2024
BREAKING CHANGE: The check_only flag is no longer available
Signed-off-by: Jennifer Power <[email protected]>
Signed-off-by: Jennifer Power <[email protected]>
Add more granular tests for dry run and reduces duplication Signed-off-by: Jennifer Power <[email protected]>
Abstracts reporting results to the console to different class and out of the entrypoint base class to allow it to extend more easily and be used in different places in the code base. Signed-off-by: Jennifer Power <[email protected]>
GitHub Actions and GitLab CI has specific formatting features that can be used to enhance the output. Also the GitHub Actions output setting has been moved to this report to remove the need to parse logs in bash Signed-off-by: Jennifer Power <[email protected]>
Signed-off-by: Jennifer Power <[email protected]>
Signed-off-by: Jennifer Power <[email protected]>
This also refines the function through the TDD process Signed-off-by: Jennifer Power <[email protected]>
Signed-off-by: Jennifer Power <[email protected]>
jpower432
force-pushed
the
feat/replace-check-only
branch
from
March 29, 2024 23:30
392fd37
to
bf72326
Compare
For more comprehensiveness, adding local commit and not push to remote in dry run feature and added change type for more detailed change reports. Signed-off-by: Jennifer Power <[email protected]>
This can be used in the release notes to show users how to migrate from check_only Signed-off-by: Jennifer Power <[email protected]>
Signed-off-by: Jennifer Power <[email protected]>
beatrizmcouto
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed during paired code review. Demonstrated during the meeting
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a dry run option, and sets output based on the information. Add the
BotResults
data class to make results easier to process as an input and output to multiple classes. Adds basic results reporting to make sure that the output is readable.Related changes are in scope of the issue, but in different commits.
Fixes #181
Rationale
Failure upon diff doesn't make sense outside of the scope of
auto-sync
. This removes that and shifts the decision to fail to the user.Use cases
push
Type of change
How has this been tested?
Checklist