Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSCE-420: ci: updates e2e testing workflow to test before image publishing #221

Merged
merged 5 commits into from
May 17, 2024

Conversation

jpower432
Copy link
Contributor

@jpower432 jpower432 commented May 14, 2024

Description

With the introduction of rebuilding on a schedule, it is better to test before the image is built to ensure
base image changes do introduce unexpected changes to the environment.

Summary

  • Move e2e.yml from a resusable workflow to a composite action to let it be run as a step or job
  • Updates ci.yml to use the action with the e2e job
  • Adds an optional testing step to the e2e action
  • Remove extra tag being created during release (validated w/ act)

Stacked with #220

Type of change

  • New feature (non-breaking change which adds functionality)

How has this been tested?

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

jpower432 added 5 commits May 15, 2024 14:48
Moves any steps that could handle secrets out of the
composite action to make it easily reusable

Signed-off-by: Jennifer Power <[email protected]>
With the introduction of rebuilding on a schedule,
it is safer to test before the image is built to ensure
base image changes do introduce unexpected changes to the
environment. Moves e2e testing to a composite action to allow it
run as a step or a job.

Signed-off-by: Jennifer Power <[email protected]>
@jpower432 jpower432 force-pushed the ci/test-before-publish branch from df451df to 9fe8aea Compare May 15, 2024 19:07
@jpower432 jpower432 marked this pull request as ready for review May 15, 2024 19:11
@jpower432 jpower432 requested review from gvauter and a team May 15, 2024 19:11
Copy link
Member

@gvauter gvauter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes lgtm, I was able to do some basic validation with act locally.

@jpower432 jpower432 merged commit a82036b into main May 17, 2024
11 checks passed
@jpower432 jpower432 deleted the ci/test-before-publish branch May 23, 2024 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants