Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update create command for e2e testing #399

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

hbraswelrh
Copy link
Contributor

Description

The fix made to create.py corrects the previously indicated profile_name to now referencecompdef_name for correct interaction with the model filter task. The change made allows for the e2e test to create the .JSON file that previously was not being created.

Fixes #391
Depends on #389

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

  • GitHub Actions e2e testing
  • Podman runner

Test Configuration:

  • Firmware version: N40ET47W (1.29 )
  • Hardware: Lenovo ThinkPad P1 Gen 4i
  • Toolchain:
  • SDK:

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Changes made to  use compdef_name reference instead of profile_name for model filter
@hbraswelrh hbraswelrh marked this pull request as ready for review December 20, 2024 18:23
@hbraswelrh hbraswelrh changed the base branch from update-compdef to update-poetry-scripts December 20, 2024 18:24
@hbraswelrh hbraswelrh self-assigned this Dec 20, 2024
Copy link
Contributor

@jpower432 jpower432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested this change locally and the JSON file is now getting created during the rules-transform pretask.

Copy link
Contributor

@qduanmu qduanmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to merge this to see if the e2e testing could be passed.

@qduanmu qduanmu merged commit aad2433 into update-poetry-scripts Dec 23, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants