Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: allow lower case in PR subject #406

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

gvauter
Copy link
Member

@gvauter gvauter commented Jan 6, 2025

Description

This change updates the commitlint config to not enforce the default rule which only allows lower-case strings in pull request titles. This is required for the current Jira/GitHub integration which requires that Jira issue keys be upper case.

References:

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gvauter gvauter requested a review from jpower432 January 6, 2025 23:01
@gvauter gvauter marked this pull request as ready for review January 7, 2025 17:42
Copy link
Contributor

@huiwangredhat huiwangredhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That could allow adding the CMPLYT to PR title. Cool. LGTM.

Copy link
Contributor

@jpower432 jpower432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gvauter gvauter merged commit 73351bc into main Jan 8, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants