Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PSCE-263: tests: adds initial end to end test for rules transform #65

Merged
merged 2 commits into from
Oct 23, 2023
Merged

PSCE-263: tests: adds initial end to end test for rules transform #65

merged 2 commits into from
Oct 23, 2023

Conversation

jpower432
Copy link
Contributor

@jpower432 jpower432 commented Oct 19, 2023 •
edited
Loading

Description

Adds end to end tests that can be run locally to verify trestle-bot functions as expected in the container.

  • Adds a mock api to provide static responses for git client using WireMock
  • Adds container images build and removal fixture
  • Adds initial command test case and response

Type of change

  • New feature (non-breaking change which adds functionality)

How has this been tested?

N/A - Only tests were added

How to test

Run make test-e2e or make test-slow to run all tests.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@jpower432 jpower432 requested a review from afflom October 20, 2023 16:48
@jpower432 jpower432 marked this pull request as ready for review October 20, 2023 23:16
@jpower432 jpower432 marked this pull request as draft October 20, 2023 23:30
@jpower432
tests: adds initial end to end tests for rules transform
1b8c7ab 
Adds a mock api to provide static responses for git client
Adds container images build and removal fixture
Adds initial command test case and response

Signed-off-by: Jennifer Power <[email protected]>
@jpower432 jpower432 marked this pull request as ready for review October 20, 2023 23:37
@jpower432
chore: incorporates PR feedback
6a18285 
Signed-off-by: Jennifer Power <[email protected]>
beatrizmcouto
beatrizmcouto approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@beatrizmcouto beatrizmcouto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Paired code review on 23 October daily call

@jpower432 jpower432 merged commit 83a0e59 into complytime:main Oct 23, 2023
7 checks passed
@jpower432 jpower432 deleted the PSCE-263 branch March 26, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beatrizmcouto beatrizmcouto beatrizmcouto approved these changes

@afflom afflom Awaiting requested review from afflom

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpower432 @beatrizmcouto