Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removes todo comments #78

Merged
merged 1 commit into from
Nov 9, 2023
+1 −7
Merged

chore: removes todo comments #78

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions trestlebot/entrypoints/entrypoint_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,6 @@

logger = logging.getLogger(__name__)

# TODO: Consider adding support for a config file or environment variables to set these values


class EntrypointBase:
"""Base class for all entrypoints."""
Expand Down
2 changes: 1 addition & 1 deletion trestlebot/transformers/base_transformer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

"""Base transformer for rules."""

# TODO: Evaluate if this should be contributed back to trestle
# Evaluate if this should be contributed back to trestle

from abc import abstractmethod
from typing import Any
Expand Down
4 changes: 0 additions & 4 deletions trestlebot/transformers/validations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,6 @@ def handle(self, data: Any, result: ValidationOutcome) -> None:
self.next_handler.handle(data, result)


# TODO(jpower432): Create a class for Profile validation to ensure unique
# entries exists in the workspace.


def parameter_validation(data: Dict[str, Any], result: ValidationOutcome) -> None:
"""Parameter logic additions validation."""
rule_info: Dict[str, Any] = data.get(const.RULE_INFO_TAG, {})
Expand Down
Loading