Update the 5.10 release branch

[hyp]

No description provided.

[compnerd]

I don't understand the revert. That effectively disables macros doesn't it?

[hyp]

I don't understand the revert. That effectively disables macros doesn't it?

This caused the following failure, so I disabled this specific change:

Run $module = "C:\a\swift-build\swift-build/BinaryCache/1/cmake/modules/SwiftSyntaxConfig.cmake"
Get-Content: C:\a\_temp\4742a4db-1ae7-4860-91b8-d9d7235cc3c4.ps1:4
Line |
   4 |  (Get-Content $module).Replace("${bindir}", '<BINARY_DIR>') | Set-Cont …
     |   ~~~~~~~~~~~~~~~~~~~
     | Cannot find path 'C:\a\swift-build\swift-build\BinaryCache\1\cmake\modules\SwiftSyntaxConfig.cmake' because it
     | does not exist.

Should I bring back that commit?

[compnerd]

Hmm, I believe that change should be in the 5.10 release, so this seems like something to investigate (or we might have regressed on 5.10 with the macros support 🤦‍♂️).

[hyp]

Hmm, I believe that change should be in the 5.10 release, so this seems like something to investigate (or we might have regressed on 5.10 with the macros support 🤦‍♂️).

cool, let me see if I can dig into it more.

[hyp]

@compnerd it's ready now, but I need to merge swiftlang/swift#70500 first

[hyp]

@compnerd looks like this branch is protected and even a rebased merge isn't working here