Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mac build] Add zlib to the Mac build #824

Merged
merged 1 commit into from
Sep 4, 2024
Merged

Conversation

Steelskin
Copy link
Collaborator

  • Make zlib version an input so it only needs to be set once.
  • Add matrix for Windows and Darwin targets. For now, Darwin does not build Android targets.

* Make zlib version an input so it only needs to be set once.
* Add matrix for Windows and Darwin targets. For now, Darwin does not
  build Android targets.
Copy link
Owner

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to reduce the split and have a single job for zlib, curl, libxml2 that just extends the build matrix?

@Steelskin
Copy link
Collaborator Author

Steelskin commented Sep 4, 2024

Is there a way to reduce the split and have a single job for zlib, curl, libxml2 that just extends the build matrix?

We can definitely merge all 3 jobs into one since they pretty much do the same thing except with different repos. It would add a bit more build time since they would no longer run in parallel but they are pretty fast already and the other jobs are already waiting on the compilers job already.
I am a bit reluctant to do these kind of larger changes at the same time because of the added risks but I'm making a note to improve this once the Mac build is complete.

EDIT: Filed #825 for this.

@compnerd compnerd merged commit a7d51e9 into main Sep 4, 2024
@compnerd compnerd deleted the fabrice/mac-build-zlib branch September 4, 2024 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants