long syntax for device mapping #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @idsulik |
ndeloof
force-pushed
the
device_mapping
branch
from
8bc4f54
to
c79a899
Compare
jhrotko
reviewed
Aug 19, 2024
| Source string `yaml:"source,omitempty" json:"source,omitempty"` | ||
| Target string `yaml:"target,omitempty" json:"target,omitempty"` | ||
| Permissions string `yaml:"permissions,omitempty" json:"permissions,omitempty"` | ||
| } |
There was a problem hiding this comment.
Missing Extension? From compse-spec you defined the pattern for Extensions
| name: load-device-mapping | ||
| services: | ||
| test: | ||
| devices: |
There was a problem hiding this comment.
Could you also introduce the test case for the object/map case (with an extension)?
ndeloof
force-pushed
the
device_mapping
branch
3 times, most recently
from
a9798f8
to
cafb985
Compare
Signed-off-by: Nicolas De Loof <[email protected]>
ndeloof
force-pushed
the
device_mapping
branch
from
cafb985
to
ef92f39
Compare
jhrotko
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introduce long syntax for device mapping, to help disambiguate path with colons
closes docker/compose#12052