Add path comparison operations #2926
Open
+1,906
−340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harendra-kumar
force-pushed
the
split-path
branch
from
bc759a1 to
7dd104d
Compare
2 tasks
adithyaov
reviewed
Jan 18, 2025
| Int -> ((a -> Bool) -> Stream m a -> Stream m (Int, Int)) | ||
| -> (a -> Bool) -> MutArray a -> m (MutArray a, MutArray a) | ||
| revBreakUsing adj indexer predicate arr = do | ||
| r <- D.head $ indexer predicate (readRev arr) |
There was a problem hiding this comment.
Should this be D.last?
Can you add some simple doctests to this?
adithyaov
reviewed
Jan 18, 2025
| {-# INLINE breakEndBy #-} | ||
| breakEndBy :: (MonadIO m, Unbox a) => | ||
| (a -> Bool) -> MutArray a -> m (MutArray a, MutArray a) | ||
| breakEndBy = breakUsing 0 D.indexEndBy |
There was a problem hiding this comment.
Can you add some simple doctests to break-ish combinators?
adithyaov
reviewed
Jan 18, 2025
Comment on lines
+2971
to
+2977
| len1 = len + adj | ||
| arr0 = | ||
| if len1 >= arrLen | ||
| then empty | ||
| else unsafeGetSlice 0 (arrLen - len1) arr | ||
| in return (arr0, unsafeGetSlice (arrLen - 1 - i) len arr) | ||
| Nothing -> return (arr, empty) |
There was a problem hiding this comment.
This looks incorrect to me. Can you add doctests to this?
adithyaov
reviewed
Jan 18, 2025
|
|
||
| where | ||
|
|
||
| getStart cur = do |
There was a problem hiding this comment.
getStart and getLast can possibly be moved out.
Perhaps indexBy and indexByRev.
adithyaov
reviewed
Jan 18, 2025
| -- >>> isValidWin "\\\\??\\x" | ||
| -- True | ||
| isValid :: (Integral a, Unbox a) => OS -> Array a -> Bool | ||
| isValid Posix path |
There was a problem hiding this comment.
Skimmed through this as you've already written a lot of doctests.
|
Few comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.