New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scope overriding join relation query #615

Open

henriquetatagiba wants to merge 1 commit into composite-primary-keys:master from henriquetatagiba:master

henriquetatagiba commented Aug 28, 2024 •

edited

Loading

Adding scopes after the join relation removes the join query from the generated SQL.

Rearrange code to match rails 7.0 method

Example:

class User < ApplicationRecord
  has_many :features, -> { enabled }
end

class Feature < ApplicationRecord
  scope :enabled, -> { where.not(user_id: nil).where(enabled: true) }
end

# User.joins(:features).to_sql
# INNER JOIN query won't include `users.id = features.user_id` but only `features.user_id IS NOT NULL`
# when the expected is both


          Fix fk scope removes join query

f019507

henriquetatagiba changed the title ~~Fix scope removes join query~~ Fix scope overriding join relation query

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet