Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COMCL-707: Fix Case Type Category Terms #1034

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

shahrukh-compuco
Copy link

Overview

This pr fixes the case type category terms usages. Currently awrads and prospect also uses the term 'cases' instead of awards and prospect on dashboard pages.

Before

image-20240807-080655

After

image-20240807-080743

@shahrukh-compuco shahrukh-compuco force-pushed the comcl-707-fix-case-category-terms branch from d51df99 to e1b8ca8 Compare August 16, 2024 11:44
@shahrukh-compuco shahrukh-compuco merged commit ad19a83 into 4.2.0-dev Aug 19, 2024
2 checks passed
@shahrukh-compuco shahrukh-compuco deleted the comcl-707-fix-case-category-terms branch August 19, 2024 09:24
@jamienovick
Copy link

@shahrukh-compuco would you mind briefly explaining how this was fixed? Just I seem to recall us fixing this a few times and I want to make sure we've caught it in a sustainable way!

@shahrukh-compuco
Copy link
Author

@jamienovick not sure about the issue last time but this time the issue was that we set case type category in cache and later on we use it to replace words as per case type category. But there was an optimization in newer version due to which the file in which we were setting the case type category in cache is read only once for the first request and then the output of the file itself is set in cache and for later requests this file output is read from cache without calling the actual file.

So if user opens awards page in the first request then the output of this file will be cached in which the case type category is set as awards and for later calls even if user visits prospect or cases it will still use awards until the cache is cleared.

In this pr I have moved the setting of case type category in cache from this file to a hook that will run for these case type category pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants