Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAE-823: Align with latest CiviCRM version 5.51 #870

Merged
merged 35 commits into from
Jan 20, 2023

Conversation

olayiwola-compucorp
Copy link

@olayiwola-compucorp olayiwola-compucorp commented Sep 6, 2022

Overview

This PR is in order to make the extension compatible with CiviCRM version 5.51
Some of the issues that have been identified and fixed are

  1. The extension causes almost every page of CiviCRM to throw PHP Fatal error and display a blank screen. this was fixed in this PR Fatal PHP Error with Civi Core 5.47 #848
  2. Custom Fields are displayed twice in the CiviCase form, this has been fixed by this PR Remove unnecessary DisplayAllCustomGroupsInCaseForm build Form hook #827
  3. Bulk Mail to multiple cases is not sending as expected, the emails are sent to each client multiple times and tokens are not resolved, this was resolved with this PR .
  4. Fix UI not showing the right labels for other case_type_categories PR
  5. Is CiviCase not compatible with API Explorer #856
  6. CiviCRM 5.43+ compatibility: replace civicrm/activity/email/add by civicrm/case/email/add to fix case tokens in emails #842

olayiwola-compucorp and others added 26 commits January 10, 2023 09:52
…ldForm hook. Its function is covered by core (at least in 5.42), and all it seems to do is add a duplicate of the case custom fields in the activity custom fields section of the case create form.
Before now CiviCRM uses the same class to handle sending of bulk emails in Contact/Activity Page and Case page, this has now been separated as seen in here civicrm/civicrm-core@dcecc49, so we now use this Forn path to send emails in CiviCase also
Before now civicrm uses the value in _toContactEmails to know which email to send email to, but it now uses the "to" html field. to restrict the contact emails that will be included in the bulk email for the current form,
we update the emails in the "to" field, removing those that do not belong to the current case id.
This was fixed by removing temporary classes added to support old CiviCRM version,these classes are removed as they're no longer needed in CiviCRM versionson >= 5.41.0
@olayiwola-compucorp olayiwola-compucorp force-pushed the MAE-823-align-with-civi-5.51.3 branch 2 times, most recently from 0e063b6 to 8c6a593 Compare January 11, 2023 10:16
@olayiwola-compucorp olayiwola-compucorp merged commit 761aaae into master Jan 20, 2023
@olayiwola-compucorp olayiwola-compucorp deleted the MAE-823-align-with-civi-5.51.3 branch January 20, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants