forked from civicrm/org.civicrm.civicase
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAE-823: Align with latest CiviCRM version 5.51 #870
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olayiwola-compucorp
force-pushed
the
MAE-823-align-with-civi-5.51.3
branch
from
November 23, 2022 13:02
a3fbd7f
to
c3f7530
Compare
olayiwola-compucorp
force-pushed
the
MAE-823-align-with-civi-5.51.3
branch
from
December 9, 2022 06:57
bad1eec
to
5af6755
Compare
…ldForm hook. Its function is covered by core (at least in 5.42), and all it seems to do is add a duplicate of the case custom fields in the activity custom fields section of the case create form.
Before now CiviCRM uses the same class to handle sending of bulk emails in Contact/Activity Page and Case page, this has now been separated as seen in here civicrm/civicrm-core@dcecc49, so we now use this Forn path to send emails in CiviCase also
Before now civicrm uses the value in _toContactEmails to know which email to send email to, but it now uses the "to" html field. to restrict the contact emails that will be included in the bulk email for the current form, we update the emails in the "to" field, removing those that do not belong to the current case id.
This was fixed by removing temporary classes added to support old CiviCRM version,these classes are removed as they're no longer needed in CiviCRM versionson >= 5.41.0
olayiwola-compucorp
force-pushed
the
MAE-823-align-with-civi-5.51.3
branch
2 times, most recently
from
January 11, 2023 10:16
0e063b6
to
8c6a593
Compare
MAE-823: Fix UI not showing the right labels for other case_type_categories
omarabuhussein
approved these changes
Jan 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR is in order to make the extension compatible with CiviCRM version 5.51
Some of the issues that have been identified and fixed are