Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Histopathology Generalist Training #248

Merged
merged 6 commits into from
Oct 31, 2023
Merged

Add Histopathology Generalist Training #248

merged 6 commits into from
Oct 31, 2023

Conversation

anwai98
Copy link
Contributor

@anwai98 anwai98 commented Oct 25, 2023

(WIP) Add histopathology generalist training

@anwai98
Copy link
Contributor Author

anwai98 commented Oct 27, 2023

This looks good to go. Before putting this to review, it expects three PRs from torch-em to be merged (minor data-related developments) - 163, 164, 165. The fine-tuning is in progress. Will keep posted here.

@constantinpape
Copy link
Contributor

I merged the corresponding torch_em PRs. I had a quick look here and this looks good.

@anwai98
Copy link
Contributor Author

anwai98 commented Oct 29, 2023

The trainings went through. This PR now looks good to go!

@anwai98 anwai98 marked this pull request as ready for review October 29, 2023 20:09
constantinpape
constantinpape reviewed Oct 30, 2023
View reviewed changes
Copy link
Contributor

@constantinpape constantinpape left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just one minor comment.
(And you don't have to rerun training because of this, let's just change it so that it will be taken into account for any new training runs.)

finetuning/generalists/training/histopathology/obtain_hp_datasets.py Show resolved Hide resolved
@anwai98
Copy link
Contributor Author

anwai98 commented Oct 31, 2023

The training works with the most recent fixes now. This is good to go.

@constantinpape constantinpape merged commit 02199d1 into master Oct 31, 2023
1 check passed
@constantinpape constantinpape deleted the aa-hp branch May 5, 2024 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@constantinpape constantinpape constantinpape approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anwai98 @constantinpape