Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run github actiosns CI tests on Windows, Mac and Linux #267

Conversation

GenevieveBuckley
Copy link
Collaborator

I think it's sensible to run the github actions CI tests on Windows, Mac and Linux, instead of just Linux.

That way we can catch any silly errors like accidentally hard coding forward slashes in cache directory paths, etc. that might work on Linux but fail on Windows (one example of a mistake I'm hoping not to make, but it would be nice to have the CI run a backup check for any silly problems like this)

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (71181d4) 39.72% compared to head (5c987f6) 39.91%.
Report is 21 commits behind head on dev.

Files Patch % Lines
micro_sam/sample_data.py 6.66% 14 Missing ⚠️
micro_sam/sam_annotator/_widgets.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #267      +/-   ##
==========================================
+ Coverage   39.72%   39.91%   +0.19%     
==========================================
  Files          33       33              
  Lines        4179     4191      +12     
==========================================
+ Hits         1660     1673      +13     
+ Misses       2519     2518       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@constantinpape
Copy link
Contributor

constantinpape commented Nov 8, 2023

I agree that this is a good idea!
I had a look at the current test failures and they seem to be due to:

  • Windows: the GUI test doesn't work. I suggest we disable it for windows.
  • Mac: the CI uses MPS but the memory is so small that some tests run out of memory. I suggest we set the device to CPU for those tests. (Maybe we want to introduce an env variable so that we can tell if we are in the CI and only then set the device to CPU, so that the tests can be executed with any device in principle.)

@constantinpape constantinpape merged commit 5546343 into computational-cell-analytics:dev Nov 18, 2023
5 checks passed
@constantinpape
Copy link
Contributor

I went ahead and finished this up @GenevieveBuckley

@GenevieveBuckley GenevieveBuckley deleted the test-windows-mac-linux branch December 6, 2023 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants