Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiscale image layer support #590

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Multiscale image layer support #590

wants to merge 6 commits into from

Conversation

constantinpape
Copy link
Contributor

@constantinpape constantinpape commented May 6, 2024

We currently don't support multiscale image layers and the goal of this PR is to address this.

If a user selects a multiscale image layer for embedding computation they will now be prompted to select the level to be used:

mip-embeddings

It already works for level zero, but does not work correctly for other levels yet.

What's left to do:

  1. Scale the prompts if the embeddings are computed on a level > 0. Prompts are given in the coordinate system w.r.t. scale 0, which does not match the embeddings. This is relatively simple: compute the scaling factor when computing the embeddings, add them to the state, scale prompt coordinates with it in the segmentation functions.
  2. Decide what to do for the label layer for level > 0. Currently a label layer would be create with the corresponding shape, so the segmented objects would not match the image data (which is displayed in the coordinate system of level 0). There are two options for solving this:
  • Scale the label layer with the same scale factor as in 1. (Can directly use scale functionality of the napari layer)
  • Create a multiscale layer for the labels as well (I think this is overkill and would complicate things, I would rather go with the prior option, just mentioning this here for completeness)

@constantinpape constantinpape changed the title Add initial support for multiscale image layers Multiscale image layer support May 6, 2024
@constantinpape constantinpape mentioned this pull request May 6, 2024
@constantinpape constantinpape marked this pull request as ready for review May 9, 2024 20:27
@constantinpape
Copy link
Contributor Author

This is working now for the 2d annotation tool. May still need some changes to make it work for 3d data.

@constantinpape
Copy link
Contributor Author

3D is a bit more complicated. Will revisit this next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant