Add FaCT Finetuning for SAM #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n script to include lora functionality
Closed
anwai98
commented
Sep 5, 2024
caroteu
reviewed
Sep 9, 2024
Co-authored-by: Carolin Teuber <[email protected]>
|
Hi @constantinpape, The FacT PR is good to go from our side (thanks to @caroteu). We have added an additional test for FacT method. We are working on doing some regression tests to understand a few minor details, but overall the method is good for another pair of eyes to review. Let us know if you spot something. PS. We made a slight design change in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @caroteu,
I moved your fork's branch to
micro-samrepo with all your changes in place.I'll review the PR soon (also check out your discussions from the other PR) and ping you here!. Thanks!