Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: duplicate queries.json file generation #159

Merged
merged 1 commit into from
May 29, 2024

Conversation

MaximStockmans
Copy link
Contributor

Closes #145

Problem

The queries.json file was generated twice, once in the current working directory and once in the build directory. The file was first generated in the current working directory, and then passed to webpack for bundling. This bundling copied the file to the build directory, causing the file to exist twice.

Solution

Removed the queries.json file from the entries in the webpack plugin and instead wrote a custom plugin that moves this file into the build folder when webpack is triggered.

@CLAassistant
Copy link

CLAassistant commented May 28, 2024

CLA assistant check
All committers have signed the CLA.

@rubensworks rubensworks merged commit 165f3fb into comunica:master May 29, 2024
7 checks passed
@rubensworks
Copy link
Member

Thanks @MaximStockmans!
Feel free to claim the bounty via https://opencollective.com/comunica-association ! (you can add VAT if needed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate file
3 participants