Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate compiler executable via profile configuration #566

Merged
merged 3 commits into from
Sep 20, 2023

Conversation

jcar87
Copy link
Contributor

@jcar87 jcar87 commented Sep 20, 2023

Propagate the compiler executables via the tools.build:compiler_executable Conan configuration in the generated profile.

This is particularly necessary when the compiler the CMake build is configured with is anything other than what CMake would auto-detect. This fixes an issue where if not propagated, when building dependencies from source (due to --build=missing), Conan might pass flags that are Clang-only, when CMake detects the system default (likely to be gcc).

Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good

conan_provider.cmake Outdated Show resolved Hide resolved
conan_provider.cmake Outdated Show resolved Hide resolved
conan_provider.cmake Outdated Show resolved Hide resolved
@jcar87 jcar87 merged commit 7cd3cfe into conan-io:develop2 Sep 20, 2023
4 checks passed
@jcar87 jcar87 deleted the lcc/feature/propagate-compilers branch September 20, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants