Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements for tests refactor #588

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Improvements for tests refactor #588

merged 3 commits into from
Nov 14, 2023

Conversation

juansblanco
Copy link
Contributor

@juansblanco juansblanco commented Nov 13, 2023 •
edited
Loading

Follow up changes to the test refactor:

  • Grouped find_modules resources with a parent folder
  • Created global test resources path variable
  • Removed unused import

@juansblanco juansblanco marked this pull request as ready for review November 13, 2023 10:25
@jcar87 jcar87 self-requested a review November 13, 2023 21:07
jcar87
jcar87 approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@jcar87 jcar87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jcar87 jcar87 merged commit 9376d81 into conan-io:develop2 Nov 14, 2023
4 checks passed
@juansblanco juansblanco deleted the js/feature/improve-tests branch November 14, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcar87 jcar87 jcar87 approved these changes

Assignees

@jcar87 jcar87

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juansblanco @jcar87