Do not pass compiler executable for AppleClang if it is the default #592
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the compiler resides in
/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc
, and that is the path that CMake registers, this cannot be invoked directly unless ones passes flags to locate the sysroot with the library etc. CMake does pass this additional information, but other tools downstream might not (e.g. Autotools, as reported in an issue). This is otherwise done automatically when invoking via/usr/bin/cc
, which in turn invokes it viaxcrun
, definingSDKROOT
properly and thus it "just works".The fix is to detect if the compiler CMake has detected is the default as found by
xcrun
- in that case, we don't propagate the compiler, and assume that it is the one that will be detected by default by downstream projects.Close #589