-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tidy ups to variable and argument names #656
Conversation
The |
Ok, no |
Can we have this merged? |
Hi @jhol The CI is red, this cannot be merged until it is green, could you please have a look? |
My mistake. I thought the test system was non-functional for this branch. The build issues should be fixed now. |
This should be ready for merge now. Is there anything I can do to help get this accepted? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks for the contribution.
This patch-set makes all variables and arguments consistent with
lower_case snake_case
style,with a underscore prefix applied to local variables.