Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add grpc #3173

Closed
wants to merge 9 commits into from
Closed

add grpc #3173

wants to merge 9 commits into from

Conversation

wolfee001
Copy link
Contributor

@wolfee001 wolfee001 commented Oct 11, 2020

Specify library name and version: lib/1.0

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot
Copy link
Collaborator

Some configurations of 'grpc/1.25.0' failed in build 1 (3d5a2e73f17015c3414f009a7d06f2aef06e054f):

Comment on lines +1 to +11
versions:
"1.25.0":
folder: all
"1.26.0":
folder: all
"1.27.0":
folder: all
"1.27.2":
folder: all
"1.27.3":
folder: all
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend adding only one version to begin (the latest for example), to quickly check errors with CI.

Copy link
Contributor

@Croydon Croydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would appreciate it very much when you would respect the MIT license and give credits when you copy MIT licensed code. This really isn't too much to ask.

Stolen from https://github.com/inexorgame/conan-grpc

Also, I don't think this is a good idea until we figured out protobuf+protoc, e.g. #2037, #2488

I would migrate the recipe myself afterwards, after having worked on this moving target forever.

@wolfee001
Copy link
Contributor Author

I would appreciate it very much when you would respect the MIT license and give credits when you copy MIT licensed code. This really isn't too much to ask.

Stolen from https://github.com/inexorgame/conan-grpc

Also, I don't think this is a good idea until we figured out protobuf+protoc, e.g. #2037, #2488

I would migrate the recipe myself afterwards, after having worked on this moving target forever.

Since you didn't reply on my email ent you directly, i wanted to move forward. Missing the credits is my bad, really sorry about that.
That would be nice, if you migrated your solution (as I proposed in my email sent to you about a month ago), but since the two referenced PRs seems to be quite pending, I don't think it would move on soon.
I close the PR if you want me to, but i think this package would be really helpful for the community.

Stolen... pff...

@Croydon
Copy link
Contributor

Croydon commented Nov 5, 2020

Please only send me emails for sensitive or private requests. I can't provide personal support via email and stopped attempting to do so. Use the respective issue tracker which is https://github.com/inexorgame/conan-grpc for this case.

Like for every Conan recipe I'm working on, the goal is to eventually migrate it to the Conan Center Index (which I also have said on numerous issues and PRs related to gRPC). But many recipes just aren't ready yet as CCI has increased quality demands (which is a good thing) or because they simply don't work well enough yet.

I have updated both my personal profile and the readme of the conan-grpc repository to make those two points clear.

In your email you described your need for a Conan cache / remote and said that Bintray has no binaries for gRPC. This is not true. The readme directly tells you what the remote is: https://github.com/inexorgame/conan-grpc#add-remote. A quick look in the issue tracker would also have reminded you of that.

If you are allowed to use other Conan remotes from Bintray than the official Conan Center remote, add the inexorgame remote for gRPC itself and the Bincrafters remote for the older Protobuf and Protoc packages and you are good to go.

I'm the core maintainer of the gRPC recipe since 2017 and getting the recipe to support the latest gRPC version and, more importantly, making it actually work rock solid is not as trivial as it might seem on first sight.

The interest in a gRPC package is quite huge and several people said hello and expressed interest to help me move things forward faster, well, every single one of those people vanished after a few days.

gRPC is regularly adding new requirements for which someone needs to create own Conan recipes along the way or updating existing recipes for new versions. We did almost completely caught up on this one, also thanks to much more new contributors since the start of CCI.

Even more of a blocker, many things required new Conan client features, but we caught now up in this area quite good as well.

The last really huge blocker is getting the protobuf+protoc recipe more stable and more up-to-date, but we are close on this one too. Afterwards, gRPC will require similar workarounds for the location problem of executables as the protobuf+protoc recipe and similar heavy patching of the CMake files, so that the mix of generated CMake files + upstream CMake files work well enough together. Related to this: components support (for which I have already a draft). If those are done, I'm confident enough to attempt a migration to CCI and see how it goes.

Though, to get both gRPC and Protobuf rock solid we need more Conan client features to better handle executables (conan-io/conan#7240, conan-io/conan#7324, probably others...)

Cross-compiling support will probably require more work after that as well.

For the moment, I think closing this PR is best.

@wolfee001 wolfee001 closed this Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants