Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added option to disable stack protection for SQLiteCpp #8434

Merged
merged 1 commit into from
Dec 20, 2021
Merged

Added option to disable stack protection for SQLiteCpp #8434

merged 1 commit into from
Dec 20, 2021

Conversation

maximiliank
Copy link
Contributor

@maximiliank maximiliank commented Dec 14, 2021 •
edited
Loading

Specify library name and version: SQLiteCpp/3.1.1

Using MinGW on Windows it is required to disable stack protection for SQLiteCpp. It is supported by the CMake variable SQLITECPP_USE_STACK_PROTECTION, see SRombauts/SQLiteCpp#286

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the conan-center hook activated.

@CLAassistant
Copy link

CLAassistant commented Dec 14, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

Sign in to view
@maximiliank maximiliank mentioned this pull request Dec 15, 2021
Open
@prince-chrismc prince-chrismc mentioned this pull request Dec 16, 2021
Open
@conan-center-bot
Copy link
Collaborator

All green in build 2 (53281d1c7e4b1402439ffb2c134b9e20b0c81601):

  • sqlitecpp/2.4.0@:
    All packages built successfully! (All logs)

  • sqlitecpp/2.5.0@:
    All packages built successfully! (All logs)

  • sqlitecpp/3.1.1@:
    All packages built successfully! (All logs)

@SSE4 SSE4 requested a review from uilianries December 18, 2021 06:25
uilianries
uilianries approved these changes Dec 20, 2021
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit 3cf049e into conan-io:master Dec 20, 2021
miklelappo pushed a commit to miklelappo/conan-center-index that referenced this pull request Feb 9, 2022
@maximiliank @miklelappo
(conan-io#8434) Added option to disable stack protection for SQLiteCpp
1d4915b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SSE4 SSE4 SSE4 approved these changes

@ericLemanissier ericLemanissier ericLemanissier approved these changes

@uilianries uilianries uilianries approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@maximiliank @CLAassistant @conan-center-bot @SSE4 @ericLemanissier @uilianries