Simplify license deployer, support nested folders #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the super quick fix/turnaround time! This looks a lot cleaner and I copied the file locally and verified it now correctly handles OpenSSL and nlohmann JSON :) |
memsharded
approved these changes
Sep 27, 2024
| search_dir = os.path.join(d.package_folder, "licenses") # This is the CCI convention | ||
| if not os.path.isdir(search_dir): | ||
| continue | ||
| with zipfile.ZipFile(os.path.join(output_folder, 'licenses.zip'), 'w') as licenses_zip: |
There was a problem hiding this comment.
I like somehow that the deployer has separated the recollection and the zipping, so users that don't want the final zip, they can just remove those lines from their fork of this deployer.
But I think it is also good as this proposes, not a big deal, clear enough ,and it handles the nested folder, so already an improvement over the existing one, good for me.
czoido
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies the license depolyer, while also adding support for nested license folders
It fixes a bug where the folder structure would be left in the output folder, but which didn't contain the licenses themselves. We now directly zip the licenseses
Closes #161
cc @lia-viam